package-info.nvim icon indicating copy to clipboard operation
package-info.nvim copied to clipboard

style: add selene for diagnostics

Open pedro757 opened this issue 3 years ago • 4 comments

selene is better in diagnostic than luacheck and sumneko-lua , check it out here

pedro757 avatar Jun 07 '22 13:06 pedro757

Hey, thanks for the PR. Will take a look at this one as well as the other ones you opened this weekend.

vuki656 avatar Jun 07 '22 16:06 vuki656

Can you elaborate a bit more on why it's better?

vuki656 avatar Jun 17 '22 12:06 vuki656

Selene is faster than luacheck and sumneko-lua diagnostics, it's fully customizable, it has many options, it is maintained, luacheck is not maintained, sumneko is not customizable.

pedro757 avatar Jun 17 '22 13:06 pedro757

I'm using the maintained version of luacheck so that shouldn't be an issue.

Speed shouldn't be an issue since the codebase is very small.

Not sure how sumneko plays a role here since that's a language server.

Can you run selene over the entire codebase? If there are some meaningful mistakes I made that selene cought, I'll think about merging this.

vuki656 avatar Jun 17 '22 13:06 vuki656