sound icon indicating copy to clipboard operation
sound copied to clipboard

chore: fix sprite id type

Open Max-0n opened this issue 1 year ago • 6 comments

Sprite ID's uses string type

const { play } = useSound('/path/to/sprite.mp3', {
  sprite: {
    laser: [0, 300],
    explosion: [1000, 300],
    meow: [2000, 75],
  },
})

My commit fix type issue while call play cb

play({ id: 'kick' })

Max-0n avatar Jan 09 '25 15:01 Max-0n

@Tahul Please implement, this tiny error upsets my TypeScript

QkeleQ10 avatar Feb 02 '25 21:02 QkeleQ10

@ThatOneCalculator i can't merge this fix... pls, do it by yourself

Max-0n avatar Dec 01 '25 11:12 Max-0n

@Max-0n I can't merge either

ThatOneCalculator avatar Dec 01 '25 15:12 ThatOneCalculator

why not? what i should to to to merge it?

Max-0n avatar Dec 01 '25 17:12 Max-0n

......because I don't belong to this project?? I literally do not have permission to merge it.

ThatOneCalculator avatar Dec 01 '25 17:12 ThatOneCalculator

Not sure why you are all pinging each other - neither of you would have merge permissions. This is @Tahul 's job, but I don't think this is being maintained anymore.

QkeleQ10 avatar Dec 01 '25 17:12 QkeleQ10