schema-org icon indicating copy to clipboard operation
schema-org copied to clipboard

Event schema node development?

Open cyruscollier opened this issue 2 years ago • 2 comments

Does anyone have an idea of when the Event node will be available in this library? The docs say it's in development, but I don't see it anywhere in the repo. I need to implement the Event schema in a Nuxt 3 app that's going into production soon. If work hasn't begun on it yet, I'd be happy to implement Event myself and submit a PR for it. It doesn't look too time-consuming to add the spec and test files for a new schema node.

cyruscollier avatar Jun 20 '22 00:06 cyruscollier

Hey @cyruscollier

I'm on leave at the moment, happy to look into this when I'm back and settled (2 weeks)

Otherwise please free to submit a PR 🙂

harlan-zw avatar Jun 27 '22 19:06 harlan-zw

Thanks, @harlan-zw . I've started a PR:

https://github.com/vueuse/schema-org/pull/10

I tried to be as thorough as I could implementing all of the related specs required to build Event, but I only went 1-2 levels deep in most cases to cover interfaces that might be commonly used in the future, so it's not perfect. I still need to add good tests for the new nodes, which I will try and get to in the next week, but I thought I'd open the PR now to at least get a conversation going if this is a good direction for these additions.

cyruscollier avatar Jul 07 '22 16:07 cyruscollier

Hey @cyruscollier

Sorry for the long lead time on this, I've just finished up v1 with the Event node included

Going to close this off, but if you any issues or such please re-open.

Thanks again for the contribution!

harlan-zw avatar Aug 24 '22 04:08 harlan-zw

Awesome!

cyruscollier avatar Aug 27 '22 11:08 cyruscollier