vuetify-loader icon indicating copy to clipboard operation
vuetify-loader copied to clipboard

fix: sourcemap not found and loading crash in nuxt

Open linspw opened this issue 1 year ago • 9 comments

Hello everything is fine? This Pull request has 3 objectives:

  • Help to better organize the vite plugin (separate responsibilities from roles)
  • Fix the bug where nuxt couldn't find the style files (because of the relative path) and it crashed.
  • Fix the lib virtual prefix, to use nuxt main pattern.

BUGS:

  1. The relative path of the target was making the nuxt load break, for some reason the path was generating a url that didn't match the file.

  2. The other sourcemap bug was caused by the \0 prefix, where the virtual is what nuxt is prepared to read (I imagine this change won't break vite builds).

https://github.com/vuetifyjs/vuetify-loader/issues/311 https://github.com/vuetifyjs/vuetify-loader/issues/290

Thanks in advance for your attention, feel free to adjust.

linspw avatar Aug 28 '23 20:08 linspw

👍 Hope this helps

Islati avatar Sep 11 '23 13:09 Islati

Hi @KaelWD .

If it's not a problem, could you see if this PR makes sense please?

linspw avatar Sep 20 '23 11:09 linspw

@KaelWD Can you please review it?

jd-solanki avatar Sep 30 '23 13:09 jd-solanki

any news?

mostafaznv avatar Oct 08 '23 07:10 mostafaznv

will this merged?

hi-reeve avatar Oct 09 '23 02:10 hi-reeve

Hello guys,

Any expected timeline on when this will be fixed?

It's the only thing that stops Nuxt users from being able to customize SASS variables.

borghol avatar Nov 26 '23 06:11 borghol

Hello, is there any news on this? hope it gets merged soon

muhammadmahmoud98 avatar Nov 28 '23 09:11 muhammadmahmoud98

This wasn't merged because it basically rewrites the entire plugin for no reason, if it's still relevant please only include changes necessary to fix the issue.

KaelWD avatar Dec 08 '23 12:12 KaelWD

Hi @KaelWD I wanted to inform you that I've created a new pull request (#328) addressing the feedback provided on the original pull request (#313).

franz-bendezu avatar Jan 01 '24 00:01 franz-bendezu