vue-storefront icon indicating copy to clipboard operation
vue-storefront copied to clipboard

Published 20 hours ago • verified publisher icon vuestorefront

Updated de.js language file

Open hackbraten68 opened this issue 3 years ago • 3 comments
trafficstars

Description

Changed a few auto-translations into grammar checked german.

Related Issue

no issues

Motivation and Context

current language file had some issues according google translation. this PR solves this and now grammatically proper german.

How Has This Been Tested?

no test needed, only language file update. no code changes

Screenshots:

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have read the CONTRIBUTING document.

Changelog

  • [x] I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • [ ] I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • [ ] I have written test cases for my code
  • [ ] I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

I tested manually my code, and it works well with both:

  • [ ] Default Theme
  • [x] Capybara Theme

Code standards

  • [x] My code follows the code style of this project.

Docs

  • [ ] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.

hackbraten68 avatar Jan 21 '22 21:01 hackbraten68

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 21 '22 21:01 CLAassistant

@hackbraten68 please update the PR title following the https://github.com/vuestorefront/vue-storefront/blob/main/CONTRIBUTING.md guide please :)

bloodf avatar Jan 21 '22 22:01 bloodf

@bloodf updated PR (wasn´t sure about most checkboxes, because it´s just a language file.

hackbraten68 avatar Jan 24 '22 10:01 hackbraten68

Hey @hackbraten68 . It looks like Heitor never merged your PR and I wasn't aware of it. Unfortunately I have to close it.

Thank you so much for contributing anyway! I hope next time will be better!

filrak avatar Aug 30 '23 15:08 filrak