vue-storefront-api icon indicating copy to clipboard operation
vue-storefront-api copied to clipboard

Published 20 hours ago • verified publisher icon vuestorefront

Add support for SVG files

Open ThermScissorpunch opened this issue 5 years ago • 5 comments

The VSF API doesn't process SVG files. It simply returns an empty response. Since SVG files are vector I skipped the resize and cropping and return the SVG files as they are originally, using the toString method because they need to be returned as text.

ThermScissorpunch avatar Aug 11 '20 06:08 ThermScissorpunch

That's cool and it makes all the sense, please just fix the conflicts and we can merge it

pkarw avatar Aug 19 '20 19:08 pkarw

@ThermScissorpunch Can you update branch, please?

gibkigonzo avatar Sep 08 '20 12:09 gibkigonzo

Any idea how to fix this? When I merge in develop from the Divante branch I get the following message: fatal: refusing to merge unrelated histories

ThermScissorpunch avatar Sep 08 '20 13:09 ThermScissorpunch

Normally I would remove local branch, create new one from develop, cherry-pick changes from remote and force push new branch. But here we have master branch. If you can please close this pre and create new one from develop branch

gibkigonzo avatar Sep 09 '20 05:09 gibkigonzo

Hello @ThermScissorpunch . It is really awesome PR but could you please resolve conflicts?

Fifciu avatar Sep 14 '20 07:09 Fifciu