vsf-capybara icon indicating copy to clipboard operation
vsf-capybara copied to clipboard

Menu items disappear after error page

Open daksamit opened this issue 5 years ago • 5 comments

Current behavior

Menu items disapear when we got error page i click home icon.

Expected behavior

Items should be visible

Steps to reproduce the issue

  1. go to homepage

image

  1. go to /error (or when error occurs)

image

  1. click vsf logo to go home

image

  1. menu items disappeared

Can you handle fixing this bug by yourself?

  • [ ] YES
  • [x] NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

daksamit avatar Nov 16 '20 17:11 daksamit

I think it's related to 'minimal' layout for ErrorPage when we back to 'default' one

daksamit avatar Nov 17 '20 10:11 daksamit

Hi @daksamit, you're right. This is because we chose to use Minimal layout not he error page instead of the Default layout. You can change this in your router settings if this isn't what you want. I would say this isn't a bug.

dt2patel avatar Nov 27 '20 10:11 dt2patel

Yes, it's ok. I think it could be confusing when user click home from error page, and "layout is not changing back"

daksamit avatar Nov 27 '20 10:11 daksamit

Ok sorry, I see what you are saying. That is definitely a bug and we should fix it. Are you interested in picking it?

dt2patel avatar Nov 27 '20 10:11 dt2patel

Oh currently, not really ;<

On Fri, Nov 27, 2020, 11:38 dt2patel [email protected] wrote:

Ok sorry, I see what you are saying. That is definitely a bug and we should fix it. Are you interested in picking it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DivanteLtd/vsf-capybara/issues/539#issuecomment-734768309, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWVQLLY6AFVNRACFGWEXU3SR56RFANCNFSM4TXPBXJQ .

daksamit avatar Nov 27 '20 17:11 daksamit