vsf-capybara icon indicating copy to clipboard operation
vsf-capybara copied to clipboard

Corrected displayed the ratings stars.

Open dimasch opened this issue 5 years ago • 9 comments
trafficstars

Related Issues

Closes #524

Short Description and Why It's Useful

Will loads actual review from ElasticSearch.

Screenshots of Visual Changes before/after (If There Are Any)

Before: Снимок экрана 2020-10-20 в 18 18 30

After: Снимок экрана 2020-10-20 в 18 30 05

Contribution and Currently Important Rules Acceptance

dimasch avatar Oct 20 '20 14:10 dimasch

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 20 '20 14:10 CLAassistant

review.ratings.length > 0 ? review.ratings[0].value

I think this should be calculating the average rating value based on the number of reviews rather than taking the first rating value.

dsitovs avatar Oct 30 '20 13:10 dsitovs

@dsitovs Yes, possible, m2 supports a multiple review criteria. Снимок экрана 2020-10-30 в 17 22 05

dimasch avatar Oct 30 '20 13:10 dimasch

This is solution will works for one super criteria of rating, if send from frontend for one stars line.

dimasch avatar Oct 30 '20 13:10 dimasch

In SF UI missing the rating control for send rating, and not possible to implement sending start, but i can add to merge request solution based on https://www.npmjs.com/package/vue-star-rating

dimasch avatar Oct 30 '20 13:10 dimasch

Hey @dimasch , please update the change logs, the changes looks good.

AishwaryShrivastav avatar Apr 13 '21 12:04 AishwaryShrivastav

@AishwaryShrivastav Okay, sorry. I will try today.

dimasch avatar Apr 13 '21 13:04 dimasch

@AishwaryShrivastav Okay, sorry. I will try today.

No rush, you can do it 2 -3 days Thanks for your reply

AishwaryShrivastav avatar Apr 13 '21 13:04 AishwaryShrivastav

@dimasch, long time no see. I'll get this merged asap if you can resolve this change log. Thanks!

dt2patel avatar Sep 06 '21 16:09 dt2patel