storefront-ui icon indicating copy to clipboard operation
storefront-ui copied to clipboard

chore(hero): add w-full to image

Open FRSgit opened this issue 1 year ago • 2 comments

Related issue

https://github.com/vuestorefront/unified-storefronts/pull/1237#issuecomment-2069309576

Closes #

Scope of work

Without w-full the image behaves weirdly when the container is not 100% width

Screenshots of visual changes

Checklist

  • [x] Self code-reviewed
  • [x] Changes documented
  • [x] Semantic HTML
  • [x] SSR-friendly
  • [x] Caching friendly
  • [x] a11y for WCAG 2.0 AA
  • [x] examples created
  • [x] blocks created
  • [x] cypress tests created

FRSgit avatar Apr 22 '24 14:04 FRSgit

⚠️ No Changeset found

Latest commit: 71cd1f8ae701c30bf4f427d23a91195958586dc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 22 '24 14:04 changeset-bot[bot]

@FRSgit you need to rebase/merge main into your branch, because file .nvmrc is required for CI

Szymon-dziewonski avatar Apr 23 '24 08:04 Szymon-dziewonski