storefront-ui
storefront-ui copied to clipboard
[BUG] Remove $parent and $children handlers
Describe the bug Using this.$parent and this.$children for operating on the dom is considered a bad practice and is not working for most of the website builders. We should remove it from following components:
- SfTabs
- SfAccordion
- SfComponentSelectOption
- SfToastItem
- SfContentCategory
- SfContentPage
- SfFooterColumn
- SfTab
┆Issue is synchronized with this Jira Zadanie by Unito
Hi, @aniamusial , I would like to take this issues, but we need to discuss what to replace $parents and $children with. as it seems to me, this.$parent can be replaced with provide/inject, and this.$children on refs, what do you think?
Hi @shatanov, I can assign this task to you if you're still interested in it :) when it comes to your question about of solving this, I think it's important to get rid of $parent and $children and the exact solution will be checked when PR is done :)
Hi @shatanov, I can assign this task to you if you're still interested in it :) when it comes to your question about of solving this, I think it's important to get rid of $parent and $children and the exact solution will be checked when PR is done :)
OK, I can try)
@shatanov great :) it's yours
I'm closing this ticket as it doesn't meet the requirements of LTS policy..