storefront-ui icon indicating copy to clipboard operation
storefront-ui copied to clipboard

[BUG] Remove $parent and $children handlers

Open aniamusial opened this issue 2 years ago • 4 comments

Describe the bug Using this.$parent and this.$children for operating on the dom is considered a bad practice and is not working for most of the website builders. We should remove it from following components:

  • SfTabs
  • SfAccordion
  • SfComponentSelectOption
  • SfToastItem
  • SfContentCategory
  • SfContentPage
  • SfFooterColumn
  • SfTab

┆Issue is synchronized with this Jira Zadanie by Unito

aniamusial avatar Apr 19 '22 18:04 aniamusial

Hi, @aniamusial , I would like to take this issues, but we need to discuss what to replace $parents and $children with. as it seems to me, this.$parent can be replaced with provide/inject, and this.$children on refs, what do you think?

shatanov avatar May 17 '22 21:05 shatanov

Hi @shatanov, I can assign this task to you if you're still interested in it :) when it comes to your question about of solving this, I think it's important to get rid of $parent and $children and the exact solution will be checked when PR is done :)

justyna-13 avatar May 31 '22 08:05 justyna-13

Hi @shatanov, I can assign this task to you if you're still interested in it :) when it comes to your question about of solving this, I think it's important to get rid of $parent and $children and the exact solution will be checked when PR is done :)

OK, I can try)

shatanov avatar Jun 01 '22 09:06 shatanov

@shatanov great :) it's yours

justyna-13 avatar Jun 01 '22 09:06 justyna-13

I'm closing this ticket as it doesn't meet the requirements of LTS policy..

AdamPawlinski avatar Jun 15 '23 13:06 AdamPawlinski