vendure icon indicating copy to clipboard operation
vendure copied to clipboard

Published 20 hours ago • verified publisher icon vuestorefront-community

[Feature]: update SFUI to version 0.12.0

Open Baroshem opened this issue 2 years ago • 5 comments

How the project can be improved?

update SFUI to version 0.12.0

What are the acceptance criteria?

  • [ ]

Additional information

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Baroshem avatar Feb 25 '22 13:02 Baroshem

Hi, I would like to work on this issue. Can you please assign it to me?

disha1202 avatar Feb 28 '22 06:02 disha1202

Hey @disha1202

Yes for sure, go on! If you need any help, please let me know :) Please, remember to test the project with a new Storefront UI version as it includes many breaking changes :)

Baroshem avatar Feb 28 '22 08:02 Baroshem

Hello @Baroshem

I have upgraded the version of SFUI to 0.12.0 and as per the migration guide, https://docs.storefrontui.io/iframe.html?id=releases-v0-12-x-latest-v0-12-0-migration-guide--page&viewMode=story It's important to have explicit width and height for SfImage component.

What should be the explicit height and width for SfImage component?

disha1202 avatar Mar 02 '22 11:03 disha1202

@disha1202

It depends really from the place where it is used. I would recommend checking how it is done right now and apply the same height and width to it :)

Baroshem avatar Mar 02 '22 12:03 Baroshem

@disha1202

It depends really from the place where it is used. I would recommend checking how it is done right now and apply the same height and width to it :)

Sure I'll do that. Thanks :)

disha1202 avatar Mar 02 '22 14:03 disha1202