core icon indicating copy to clipboard operation
core copied to clipboard

feat(theme-default): redesign custom container

Open quadratz opened this issue 3 years ago • 2 comments

Preview: https://cikimomogi-grammy.github.io/VP/test.html

quadratz avatar Oct 17 '22 01:10 quadratz

I personally don't think that we do need to change details container color in other blocks.

You may sperate this in several PR to have a better discussion about improving colors.

E.g.: I do think a fix for table 2n rows is needed.

Mister-Hope avatar Oct 17 '22 02:10 Mister-Hope

Okay i will split them into multiple PR

quadratz avatar Oct 17 '22 03:10 quadratz

You'd better provide Before and After screenshots for UI changes. So we can review the improvements directly

meteorlxy avatar Oct 21 '22 15:10 meteorlxy

Result:

  • Before: https://cikimomogi-grammy.github.io/vp-main/result.html
  • After: https://cikimomogi-grammy.github.io/vp-1131/result.html

quadratz avatar Oct 26 '22 14:10 quadratz

I also plan to modify the color palettes for table and details container. What do you think?

The background color of Code is too dark. Adding some adjustment. Table before: table-before Table after: table-after

Make the background color of details container match with the color of the parent container. Details Before: details-before Details after: details-after

quadratz avatar Oct 26 '22 14:10 quadratz

Yeah, go ahead. There are lots of things to be improved. Looking forward to your PR. 👍

I'll handle this one tomorrow

meteorlxy avatar Oct 26 '22 15:10 meteorlxy

Update:

  • Before: https://cikimomogi-grammy.github.io/vp-main/result.html
  • After: https://cikimomogi-grammy.github.io/vp-1131/result.html

quadratz avatar Oct 27 '22 05:10 quadratz

Update:

  • Before: https://cikimomogi-grammy.github.io/vp-main/result.html
  • After: https://cikimomogi-grammy.github.io/vp-1131/result.html

quadratz avatar Oct 30 '22 16:10 quadratz