core icon indicating copy to clipboard operation
core copied to clipboard

feat(bundler-vite): improve chunk name

Open Mister-Hope opened this issue 3 years ago • 3 comments

Mister-Hope avatar Sep 25 '22 08:09 Mister-Hope

This ensure a chunk is not started by _, solution comming from vitepress, the idea is editing the original sanitizeFileName and remove the trailling underscore.

Mister-Hope avatar Sep 25 '22 08:09 Mister-Hope

Done

Mister-Hope avatar Oct 08 '22 15:10 Mister-Hope

Edge case: people are using markdown starting with _, I will fix this and then mark this ready.

Mister-Hope avatar Oct 17 '22 08:10 Mister-Hope

Any update on reviewing this?

Mister-Hope avatar Nov 07 '22 04:11 Mister-Hope

Emm that function is redirectly copied from rollup, and was used exactly on the same option.

I though we can trust rollup code as we are using rollup ourselves. however if you do insist a unit test is still needed, I can add some. (I already add a reference link to the original function in rollup repo)

Mister-Hope avatar Dec 05 '22 13:12 Mister-Hope

OK, I forgot that is was forked from rollup. Ignore that.

meteorlxy avatar Dec 06 '22 03:12 meteorlxy