vue icon indicating copy to clipboard operation
vue copied to clipboard

fix(patch): Do not consider nodes with different scope ids the same (fix #10416)

Open NoahKa0 opened this issue 2 years ago • 5 comments

When patching a node the scope id might change. When it does the flow should be followed for updating non-same elements to make sure it is updated correctly in the DOM.

fix #10416

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] It's submitted to the main branch for v2.x (or to a previous version branch)
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [ ] New/updated tests are included

There seems to be an issue with the tests that is not related to this change. From what I can see all tests are passing since there are some issues with the tests it might be worth double checking.

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

NoahKa0 avatar Jan 18 '23 21:01 NoahKa0

what do you?

webbseo avatar Jan 24 '23 18:01 webbseo

Any updates on this? I applied this locally and which seems to have fixed the bug for me.

achung89 avatar Aug 07 '23 13:08 achung89

Any updates? Also fixes the bug locally for me.

romoncorvo avatar Oct 12 '23 07:10 romoncorvo

Same here...

andelizondo avatar Oct 13 '23 12:10 andelizondo

Same here!

dechaunb avatar Aug 02 '24 07:08 dechaunb