vue icon indicating copy to clipboard operation
vue copied to clipboard

fix: toString utils should unref the `Ref<T>`

Open enpitsuLin opened this issue 2 years ago • 1 comments

fix #12884

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] It's submitted to the main branch for v2.x (or to a previous version branch)
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [ ] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

enpitsuLin avatar Nov 30 '22 03:11 enpitsuLin

Vue3 has a replacer parameter in JSON.stringify that call in toDisplayString but as same purpose toString doesn't

I'm not sure if I need to add that parameter or just do unref for Ref<T>

enpitsuLin avatar Nov 30 '22 05:11 enpitsuLin

don't depend v3, use type

LingRen avatar Mar 27 '23 08:03 LingRen

  • It should use replacer, otherwise it won't unwrap nested refs.
  • It should not depend on v3, as it causes a circular dependency and causes runtime errors in the built version of Vue. See ae3e4b1c

yyx990803 avatar Dec 06 '23 08:12 yyx990803