vue icon indicating copy to clipboard operation
vue copied to clipboard

fix(compiler-sfc): add semicolon after `defineProps` statement

Open liulinboyi opened this issue 2 years ago • 5 comments

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] It's submitted to the main branch for v2.x (or to a previous version branch)
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [ ] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

liulinboyi avatar Nov 18 '22 11:11 liulinboyi

Please refer to the original PR in the repo of Vue 3.

sxzz avatar Nov 18 '22 11:11 sxzz

Please refer to the original PR in the repo of Vue 3.

ok, thanks!

liulinboyi avatar Nov 18 '22 11:11 liulinboyi

Please update the snapshots to fix CI issues.

ok, no problem!

liulinboyi avatar Nov 18 '22 11:11 liulinboyi

ref: https://github.com/vuejs/core/pull/6461

sxzz avatar Nov 18 '22 13:11 sxzz

ref: vuejs/core#6461

Thanks!

liulinboyi avatar Nov 18 '22 13:11 liulinboyi