vue icon indicating copy to clipboard operation
vue copied to clipboard

fix(compiler): nested scoped slot not update (fix #12232, #12245)

Open JuniorTour opened this issue 2 years ago • 5 comments

Before Fix After Fix
Issue Fix #12232
Reproduction Link https://jsbin.com/sakiwam/edit?html,output https://jsbin.com/rexakik/edit?html,output
Screenshot 07c1d1a2d9f45bbe4714417e951d86a 58e5456a8458ee88724aab0a8d54187
Issue Fix #12245
Reproduction Link https://codesandbox.io/s/vue-2-x-reactivity-broken-tqogh https://jsbin.com/gatanir/edit?html,output
Screenshot edb6f72f5584eeb0c27612cc4de0bd7 62643d55033a817bddbf8bbef0d46af

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [x] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

JuniorTour avatar Sep 08 '21 16:09 JuniorTour

Great!

hivokas avatar Sep 20 '21 11:09 hivokas

Is there anything that prevents this PR from being merged? 👀 It fixes the issue I have in the app I'm working on.

hivokas avatar Sep 23 '21 09:09 hivokas

Is there anything that prevents this PR from being merged? 👀 It fixes the issue I have in the app I'm working on.

We have to wait for code review and approval from official maintainer. 🤷‍♂️

JuniorTour avatar Oct 01 '21 04:10 JuniorTour

Curious if this will be merged? It seems to fix the discrepancy between the old and new slot syntax, which is breaking some reactivity for us within nested slots.

trevorgehman avatar Nov 24 '21 13:11 trevorgehman

Is there any plan for when to merged this?

shengnoyi avatar Mar 17 '23 04:03 shengnoyi