vue icon indicating copy to clipboard operation
vue copied to clipboard

refactor(factory): improve fallback multiple v-if

Open KSH-code opened this issue 3 years ago • 6 comments

close #11856

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [x] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [x] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

KSH-code avatar Jan 07 '21 11:01 KSH-code

This is the very first time I create Pull Request to vuejs, If description is bad, please let me know. then I'll edit.

KSH-code avatar Jan 07 '21 11:01 KSH-code

You will probably want to make this change to the source file instead of just the weex output: src/core/vdom/helpers/normalize-scoped-slots.js

sirlancelot avatar Jan 08 '21 00:01 sirlancelot

Nice to point out mistake! files of packages directory are made by build, right?

KSH-code avatar Jan 08 '21 02:01 KSH-code

@posva When it will be merged? it was reviewed over 1 year ago.

KSH-code avatar May 02 '22 07:05 KSH-code

@posva @yyx990803 When it will be merged? 🤔 I've seen release 2.7 was released.

KSH-code avatar Jun 22 '22 02:06 KSH-code

@posva @yyx990803

KSH-code avatar Aug 22 '22 11:08 KSH-code