vue icon indicating copy to clipboard operation
vue copied to clipboard

fix: binding of `muted` dom property for <audio>

Open herrernst opened this issue 4 years ago • 2 comments

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • [ ] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Binding the DOM muted property to a Vue.js property is currently working only on <video> elements, but not on <audio> elements. Example: https://jsfiddle.net/jfLkynsg/

This trivial change fixes the binding for <audio>.

herrernst avatar Aug 19 '19 13:08 herrernst

Looks good to me

allanchua101 avatar Aug 23 '19 02:08 allanchua101

It's very important for VOIP app,In VOIP app, always need to mute self audio.

imndx avatar Nov 29 '22 02:11 imndx