vue-style-loader Use same code for HMR with shadowMode

What kind of change does this PR introduce? Prior to this change, addStylesToShadowDOM would ignore styles it had already added. When developing using Hot Module Reload, it is necessary to replace existing style elements instead.

Did you add tests for your changes? No, there are no existing tests for addStylesShadow.js. Perhaps there should be, but the changes would be larger than the scope of this PR.

If relevant, did you update the README? No, the README does not reference shadow mode at all. Perhaps it should, but the changes would be larger than the scope of this PR.

Summary

I use HMR in my projects, and templates update as expected. Styles do not. This solves #38

Does this PR introduce a breaking change?

This is not a breaking change.

Other information

Aug 16 '19 22:08 alancnet

@sodatea Requesting some visibility here. Thanks!

Aug 20 '19 12:08 alancnet

Hi, I'm not sure about any potential side effect but for now this fix seems to be working smoothly. It even incidentally solved this issue. Thank you for the fix @alancnet!

Oct 28 '19 15:10 gslama-akqa

@gslama-akqa My pleasure. I have this fix published at https://www.npmjs.com/package/@alancnet/vue-style-loader if you need it.

Oct 29 '19 13:10 alancnet

File lib/addStylesShadow.js was deleted but vue/cli-service/lib/commands/build/resolveWcEntry.js tries to import it. So building production build fails but HMR works correctly.

Jan 22 '20 05:01 jwayne2