vue-style-loader icon indicating copy to clipboard operation
vue-style-loader copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

Use same code for HMR with shadowMode

Open alancnet opened this issue 4 years ago • 4 comments

What kind of change does this PR introduce? Prior to this change, addStylesToShadowDOM would ignore styles it had already added. When developing using Hot Module Reload, it is necessary to replace existing style elements instead.

Did you add tests for your changes? No, there are no existing tests for addStylesShadow.js. Perhaps there should be, but the changes would be larger than the scope of this PR.

If relevant, did you update the README? No, the README does not reference shadow mode at all. Perhaps it should, but the changes would be larger than the scope of this PR.

Summary

I use HMR in my projects, and templates update as expected. Styles do not. This solves #38

Does this PR introduce a breaking change?

This is not a breaking change.

Other information

alancnet avatar Aug 16 '19 22:08 alancnet