vue-router icon indicating copy to clipboard operation
vue-router copied to clipboard

correct typedef of Route

Open aryanbhosale opened this issue 1 year ago • 6 comments

Fixes #3566

updated typedef of interface Route from query: Dictionary<string | (string | null)[]> to query: Dictionary<string | null | (string | null)[]>

aryanbhosale avatar Aug 25 '24 11:08 aryanbhosale

Deploy Preview for vue-router-docs-v3 canceled.

Name Link
Latest commit dee25cf83d47efc0e752cd24bfa06817bcb3470b
Latest deploy log https://app.netlify.com/sites/vue-router-docs-v3/deploys/66cdaf9e95579c000874784d

netlify[bot] avatar Aug 25 '24 11:08 netlify[bot]

Can you add a test?

Which files exactly? im kinda new to this so just the files that need to be covered would be great

aryanbhosale avatar Aug 26 '24 12:08 aryanbhosale

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

posva avatar Aug 26 '24 13:08 posva

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

Thank you! Will have a look

aryanbhosale avatar Aug 26 '24 13:08 aryanbhosale

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

is my latest commit what you were looking for in the test?

aryanbhosale avatar Aug 27 '24 10:08 aryanbhosale

Thanks! That should be the test. I will take a look on my next pass over vue router 3.

posva avatar Aug 28 '24 06:08 posva

I have updated the code after reading all the comments can you please check this @posva

yash-dayama avatar Jul 31 '25 05:07 yash-dayama

This is the old non maintained version of Vue router. I only do paid reviews and release for companies

posva avatar Jul 31 '25 06:07 posva