vue-router icon indicating copy to clipboard operation
vue-router copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

fix: 🐛 treat isActive to case-insensitive

Open Kyle-Ye opened this issue 2 years ago • 3 comments

✅ Closes: #3656

Kyle-Ye avatar Oct 28 '21 12:10 Kyle-Ye

Maybe we need to add some tests for this new behavior, any suggestion where to write the new test?

Kyle-Ye avatar Oct 28 '21 13:10 Kyle-Ye

This is not the correct patch as there is an option to make the path matching case sensitive and this should respect it. This information should be available on the route records as regex.ignoreCase or something similar. Can you also add a few unit tests for isIncludeRoute?

Add the test and use regex.ignoreCase property. Any suggestion on how to safely get ignoreCase properly?

Kyle-Ye avatar Oct 28 '21 16:10 Kyle-Ye

Hello @posva. Any suggestion on this PR?

Kyle-Ye avatar Nov 08 '21 03:11 Kyle-Ye