vue-router icon indicating copy to clipboard operation
vue-router copied to clipboard

Yarn v2 compat: add vue to peerDependencies

Open AlexandreBonaventure opened this issue 5 years ago • 3 comments

Version

3.1.3

Steps to reproduce

When using Typescript, vue-router export types like here: https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L1 But as you can see here, it imports Vue typings to make it work. As a matter of fact vue should be added to peerDependencies

What is expected?

vue should be a peerDependency

What is actually happening?

it is not, and it fails in a strict dependency-tree context

Ref: https://github.com/vuejs/vue-cli/issues/5135

AlexandreBonaventure avatar Feb 12 '20 15:02 AlexandreBonaventure

for anybody doing the PR, please include clear steps about how to test locally with links to instructions to use yarn v2 as I personally don't use it

posva avatar Feb 12 '20 16:02 posva

@posva I would like to give it a shot. And also could you guide me a little bit where should I look Into ?

Blakelist7 avatar May 21 '21 14:05 Blakelist7

Generally vue should be a peer dependency as the types files import from vue but vue is neither listed as a dependency nor as a peerDependency.

susnux avatar Jun 13 '23 14:06 susnux