vue-router icon indicating copy to clipboard operation
vue-router copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

Throw error when component is undefined or null (#2038)

Open AlbertLucianto opened this issue 6 years ago • 3 comments

Add assertion when a route component is null or undefined, a fix for issue #2038.

Really appreciate for a review.

AlbertLucianto avatar Feb 02 '18 11:02 AlbertLucianto

Oh sorry I missed that. Will try to work on that.

AlbertLucianto avatar Feb 02 '18 11:02 AlbertLucianto

Keep in mind you can run the tests locally too, it will save you some time 😄

posva avatar Feb 02 '18 11:02 posva

Just now, I've tried to trace through what might be throwing error when it shouldn't. Then I found in Route Matching that the routes does not have any components nor any other options like redirections, aliases. So I think it is probably better to just warn instead of asserting error.

You might want to review it again. Anyway thanks for the guide.

AlbertLucianto avatar Feb 02 '18 12:02 AlbertLucianto