vue-issue-helper icon indicating copy to clipboard operation
vue-issue-helper copied to clipboard

We sometimes get errors from the GH API because of rate limits

Open LinusBorg opened this issue 5 years ago • 2 comments

e.g.: https://github.com/vuejs/vue-cli/issues/4588

github API call fails : api.github.com/repos/vuejs/vue-cli/releases?page=1&per_page=100 returns :

documentation_url: "https://developer.github.com/v3/#rate-limiting" message: "API rate limit exceeded for XXX.X.XXX.XXX. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)"

There's currently no error handling happening

LinusBorg avatar Sep 18 '19 11:09 LinusBorg

  1. We need some error handling here:

https://github.com/vuejs/vue-issue-helper/blob/59f0130509528253389d90cd50c05a1da74d835e/src/components/BugReport.vue#L207

  1. Assuming we can't easily/quickly get a higher rate limit from github some way, we should make sure that the issue helper works despite this, i.e. make the option field optional (...only if the versions request fails?).

  2. We could cache these version lists in localstorage so users that come back can fallback to an older list if the rate limit doesn't allow them to have an up-to-date one.

LinusBorg avatar Sep 18 '19 11:09 LinusBorg

Always reaching rate limits in my company intranet, with a universal proxy....

meteorlxy avatar Sep 23 '20 04:09 meteorlxy