vitepress icon indicating copy to clipboard operation
vitepress copied to clipboard

New local navbar design breaks ubiquitous header styling

Open elringus opened this issue 6 months ago • 4 comments

Describe the bug

https://github.com/vuejs/vitepress/pull/3359 makes it so that there are two separate headers now (VPNav and VPLocalNav), which make it impossible to apply single style for header, such as blur effect. Even if I remove the divider and border, it'll look as follow:

5a12751cb302db3d90f1af756ec4242d

Reproduction

Add blur filter to VPNav and VPLocalNav and remove borders.

Expected behavior

Both headers should be wrapped under single element (eg, <header>).

System Info

-

Additional context

No response

Validations

elringus avatar Dec 30 '23 20:12 elringus

/cc @kiaking

brc-dd avatar Dec 31 '23 10:12 brc-dd

@brc-dd Please bring back the curtain below the header instead of the black divider, the curtain looked much better. I stay on an older version of Vitepress because of that

giladgd avatar Jan 18 '24 14:01 giladgd

the curtain looked much better

That's subjective. I like the new style more. Additionally, curtain was causing UX issues, where it blocked raycast for visible elements, such as links (user could clearly see a link under the curtain, but couldn't click it).

And you can always bring the curtain back via custom CSS anyway.

elringus avatar Jan 18 '24 14:01 elringus

@elringus That's the thing, I can't just add this using purely CSS, as it requires another DOM element and depends on custom logic built around it. Having it brought back as a flag that can be enabled would also be great.

giladgd avatar Jan 20 '24 01:01 giladgd