feat: add navigation-api router
Right now I'm playing with it, once the features added we can start adding compatibility.
Looks like I've finished it, will need to review view transitions at legacy router an prepare some tests here: will port https://github.com/vuejs/router/pull/2552 PR to this PR to add some tests and a new playground.
You can play with the new Navigation API Router in my GH repo using this branch: https://github.com/userquin/vue-router-api/tree/nav-api-vue-router
Deploy Preview for vue-router canceled.
| Name | Link |
|---|---|
| Latest commit | 11632e0fabb7085619bc6551df213f93eac7d6e8 |
| Latest deploy log | https://app.netlify.com/projects/vue-router/deploys/68cb29b88fa4900008112974 |
[!IMPORTANT]
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Codecov Report
:x: Patch coverage is 7.89238% with 1027 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.10%. Comparing base (6171856) to head (11632e0).
:warning: Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2551 +/- ##
===========================================
- Coverage 94.80% 71.10% -23.71%
===========================================
Files 34 39 +5
Lines 3004 4094 +1090
Branches 846 851 +5
===========================================
+ Hits 2848 2911 +63
- Misses 153 1180 +1027
Partials 3 3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
arggg, changes in guardToPromiseFn breaks also current router, I need to review the logic: adding optional NavigationInformation parameter to guardToPromiseFn cannot be done with current method signature
https://github.com/userquin/vue-router-api/tree/nav-api-vue-router using pkg-pr-new from this PR
Maybe we can use a vue plugin for enableViewTransition, this way Nuxt can register the plugin (its current plugin can be simplified a lot with latest features added here)
arggg, back/forward view transitions broken, reviewing code