router icon indicating copy to clipboard operation
router copied to clipboard

fix: null should be preserved in relative navigations

Open posva opened this issue 1 year ago • 1 comments

The fix is a bit more complicated that I anticipated, I will come back to this later on as the currently documented version works perfectly.

  • the nullish params are removed before being passed to the matcher
  • The encodeParam function transform null into ''
  • The applyToParams also works with arrays but it makes no sense to allow null in array params

Ideally, I would make the matcher a bit more permissive so the encoding is kept at the router level. I think the matcher sholud be responsible for removing the nullish parameters but that also means the encode function should leave nullish values untouched. We might need an intermediate Type for this shape of Params, it gets a little bit tedious in terms of types, so I would like to avoid adding more types.

Close #1893

posva avatar Dec 15 '23 13:12 posva

Deploy Preview for vue-router canceled.

Name Link
Latest commit c93e259e39a96117439aa02c351b625e780e4a90
Latest deploy log https://app.netlify.com/sites/vue-router/deploys/657c61c42737a50008e91f69

netlify[bot] avatar Dec 15 '23 13:12 netlify[bot]