pinia icon indicating copy to clipboard operation
pinia copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

feat: warn when create store with exsist id

Open OXXXRA opened this issue 3 years ago • 4 comments

closes https://github.com/vuejs/pinia/issues/1394

OXXXRA avatar Aug 18 '22 11:08 OXXXRA

Deploy Preview for pinia-official canceled.

Name Link
Latest commit 5a35178c230ff0a65c75bd00818e41d284cbc662
Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/633ad0a30c96740009dd88c6

netlify[bot] avatar Aug 18 '22 11:08 netlify[bot]

@posva, hi, it's ok?

OXXXRA avatar Aug 25 '22 20:08 OXXXRA

Thanks but this seem like a copy of #1452 with only one test added... That PR implementation doesn't work, if you try it locally you will see how the console is flushed with warnings when running the tests... Also, the warning is still not dev only.

posva avatar Aug 31 '22 10:08 posva

@posva, now i added output only for dev, also checked warn output in playground. Снимок экрана 2022-08-31 в 20 08 33

OXXXRA avatar Aug 31 '22 17:08 OXXXRA

Thanks but this still doesn't work and my feedback is getting ignored so I prefer closing this so other contributors feel free to open a new PR

posva avatar Oct 06 '22 14:10 posva