pinia icon indicating copy to clipboard operation
pinia copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

fix: install devtools plugin only after app is created and installed (#1063)

Open popov-a-e opened this issue 2 years ago • 4 comments

Closes https://github.com/vuejs/pinia/issues/1063

Turned out in nuxt plugin environment, pinia._a is not yet defined which resulted in devtools unable to find app record.

popov-a-e avatar Jun 24 '22 22:06 popov-a-e

Deploy Preview for pinia-official canceled.

Name Link
Latest commit 9ea96a4cef2d9fb38d5656b4fc534eb8141a6996
Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/62b767aeaee0a700094b0c47

netlify[bot] avatar Jun 24 '22 22:06 netlify[bot]

Thanks for the PR but this completely changes the behavior of plugins. The fix should be possible with minimal changes and without changing how stores are initialized

posva avatar Jun 25 '22 18:06 posva

OK, I ended up applying same logic to devtools plugin only. Tests checked.

popov-a-e avatar Jun 25 '22 19:06 popov-a-e

@posva Hi Eduardo, is it OK now?

popov-a-e avatar Jun 28 '22 18:06 popov-a-e