pinia icon indicating copy to clipboard operation
pinia copied to clipboard

docs(zh): add Chinese docs

Open KimYangOfCat opened this issue 2 years ago • 14 comments

Hello, I want to add chinese docs for pinia. I had added zh folder, and completed the config for localisation. But I don't know if the official team is willing to add Chinese documentation,so I created this PR for comments. I will complete the translation of the document in the next few days, if the official wishes.

KimYangOfCat avatar Apr 02 '22 09:04 KimYangOfCat

Deploy Preview for pinia-official failed.

Name Link
Latest commit ccb347ad4f0d667efd719f294601f8c693108d62
Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/634ea963ab28f600092bbe76

netlify[bot] avatar Apr 02 '22 09:04 netlify[bot]

Hi, everyone, I am so happy to tell you that I have finished the chinese docs translation. If you are good to Chinese , I am willing to get your suggestion of review. Now, you can click here to preview.

KimYangOfCat avatar Apr 11 '22 14:04 KimYangOfCat

image 这里翻译成【商店】?我觉得应该是直接用store吧?

PatrickChen928 avatar Jun 08 '22 07:06 PatrickChen928

image

这里翻译成【商店】?我觉得应该是直接用store吧?

这个可能是作者机器翻译的😄

murongg avatar Jun 08 '22 07:06 murongg

image 这里翻译成【商店】?我觉得应该是直接用store吧?

这个可能是作者机器翻译的😄

估计是的。可能遗漏了吧😄

PatrickChen928 avatar Jun 08 '22 07:06 PatrickChen928

image

PatrickChen928 avatar Jun 08 '22 07:06 PatrickChen928

这个可能是作者机器翻译的😄

为了提升速度,翻译过程中确实有部分借助机翻,但都经过一次人工校对,这里应该是我疏忽了,多谢指出,我立马修改。

下次提意见的时候,如果可以的话,请按标准的 review 方式操作吧。这样可以加快 BUG 修改,你也可以成为本 PR 的贡献者,当本 PR 被 merge 之后你也可以成为仓库贡献者。目前这样的截图方式并不是很方便。

KimYangOfCat avatar Jun 08 '22 13:06 KimYangOfCat

这个可能是作者机器翻译的😄

为了提升速度,翻译过程中确实有部分借助机翻,但都经过一次人工校对,这里应该是我疏忽了,多谢指出,我立马修改。

下次提意见的时候,如果可以的话,请按标准的 review 方式操作吧。这样可以加快 BUG 修改,你也可以成为本 PR 的贡献者,当本 PR 被 merge 之后你也可以成为仓库贡献者。目前这样的截图方式并不是很方便。

ok. 我的疏忽。大致翻了下看到的问题,就直接评论了。下次我注意~

PatrickChen928 avatar Jun 08 '22 14:06 PatrickChen928

@Aimer-Fan Thanks for your review, I have fixed them. If no other suggestions, please approve this PR, thanks again!

KimYangOfCat avatar Jun 23 '22 04:06 KimYangOfCat

@posva hi, there are more than two people that has approved this PR , so can it be merged as soon as possible?

KimYangOfCat avatar Jul 16 '22 07:07 KimYangOfCat

@KimYangOfCat Could you please check other Composition API translation, and replace the Store to "状态管理" when neccessary ( e.g. in index title description) if you have spare time?

awxiaoxian2020 avatar Aug 21 '22 00:08 awxiaoxian2020

@awxiaoxian2020 thanks for your reminder. this PR has some conflicts due to update now. I will update my branch and translate new content recently, and previous tanslations will be checked again.

KimYangOfCat avatar Aug 21 '22 07:08 KimYangOfCat

And the CI seems failed. Do we need to fix it?

awxiaoxian2020 avatar Aug 25 '22 11:08 awxiaoxian2020

yes, but now there's no rush, I need to finish translating the update first. Then I will fix CI

KimYangOfCat avatar Aug 25 '22 14:08 KimYangOfCat

I think it should be merged first and improve later. @awxiaoxian2020 Agree! please approve this PR. @posva PTAL

KimYangOfCat avatar Oct 17 '22 05:10 KimYangOfCat

Thanks a lot for this @KimYangOfCat I'm still waiting for vitepress to support i18n in their newer versions, that way, the font will also be changed. Hopefull this change should be really close

posva avatar Oct 17 '22 06:10 posva

@posva I've looked at the progress of vitepress i18n and it's only about 50%, so there may be some time before it's actually released. Perhaps you could consider merging this PR first, and then I would upgrade the dependencies and modify the configuration once vitepress i18n is officially released. I believe this would not cause any more work, and it would be a good transition solution. Do you have any other concerns?

KimYangOfCat avatar Oct 17 '22 11:10 KimYangOfCat

pnpm-lock changes removed. thanks for merging! In the future, I am willing to help fix any problems about the Chinese documentation.

KimYangOfCat avatar Oct 18 '22 13:10 KimYangOfCat

Amazing merge! Does this mean that we now have open doors for other languages? @KimYangOfCat, can we have some README.md with basic instructions for adding other languages?

arnonrdp avatar Oct 18 '22 17:10 arnonrdp

Thanks for your interest! Other languages will be kept in other repositories, following the guide at https://github.com/vuejs-translations/guidelines/blob/main/README.md

posva avatar Oct 18 '22 17:10 posva

Right, but they will be in the language dropdown of the main site (https://pinia.vuejs.org/) or it will be another url.

arnonrdp avatar Oct 18 '22 18:10 arnonrdp

in the dropdown, pointing to an external site

posva avatar Oct 18 '22 18:10 posva

Later, will the docs package be split into a new repository of the vuejs-translation org? Same as vue docs? maybe we should open a new issue to discuss this.

KimYangOfCat avatar Oct 19 '22 00:10 KimYangOfCat

Later, will the docs package be split into a new repository of the vuejs-translation org? Same as vue docs? maybe we should open a new issue to discuss this.

See also https://github.com/vuejs-translations/docs-zh-cn/discussions/561

awxiaoxian2020 avatar Oct 19 '22 01:10 awxiaoxian2020