language-tools icon indicating copy to clipboard operation
language-tools copied to clipboard

[FEATURE REQUEST] Add Deno Support

Open LePichu opened this issue 3 years ago • 4 comments

As of the time of writing, Vue compilation is supported on the Deno runtime by the main compiler using Vite but also other community powered tools which use the compiler in alternate ways to get Vue working with Deno.

The last piece remaining is proper IDE support, so if possible, please consider adding a runtime option in the configuration which can be set to Deno and make Volar co-operate with Deno Language Server instead.

Currently, it almost works but does not recognize Deno Import Maps and often TypeScript files if they use Deno-specific things.

TL;DR - Please add functioning auto-complete for Deno runtime users which picks imports from Deno's import maps or URLs directly.

LePichu avatar Dec 27 '22 15:12 LePichu

@dtrifiro FYI

njhill avatar Jul 08 '24 22:07 njhill

If possible, try to add a test case to verify whether the OpenAI-compatible server can apply the correct chat template.

Thanks @DarkLight1337, yes test is forthcoming.

njhill avatar Jul 09 '24 15:07 njhill

We can merge after the test case is added.

DarkLight1337 avatar Jul 11 '24 02:07 DarkLight1337

@DarkLight1337 tests now added! and there were a lot of merge conflicts to resolve :sweat_smile:

njhill avatar Jul 18 '24 00:07 njhill

The error occurs because the ~~tokenizer~~ HuggingFace config is passed to the lru_cache from _image_token_str function, so we need to remove the lru_cache. To compensate, can a cached_property be added to CachedTokenizer so that we can avoid decoding the image token each time?

DarkLight1337 avatar Jul 18 '24 03:07 DarkLight1337

Thanks @DarkLight1337! I pushed a fix before I read your comment, hopefully this should be ok too.

njhill avatar Jul 18 '24 04:07 njhill