eslint-plugin-vue icon indicating copy to clipboard operation
eslint-plugin-vue copied to clipboard
verified publisher icon vuejs

implements autofix in define-props-declaration (#2465)

Open mpiniarski opened this issue 1 year ago • 7 comments

Fixes #2465

mpiniarski avatar May 27 '24 15:05 mpiniarski

@FloEdelmann can I get some attention to this PR?

mpiniarski avatar Jun 17 '24 13:06 mpiniarski

@FloEdelmann applied changes, please review again

mpiniarski avatar Jun 21 '24 13:06 mpiniarski

@ota-meshi Could you please clear the Netlify cache and restart the deployment? That would make the rule (and docs) changes easier to test.

FloEdelmann avatar Jul 02 '24 13:07 FloEdelmann

I cleared the cache and restart. The PR status remains failed, but it seems to have worked. https://deploy-preview-2466--eslint-plugin-vue.netlify.app/rules/define-props-declaration.html

ota-meshi avatar Jul 02 '24 23:07 ota-meshi

Should we fix it to multi-line interface, then make the separator configurable?

so1ve avatar Jul 09 '24 13:07 so1ve

No, let's keep it single-line and leave the rest to other ESLint rules or formatters like Prettier.

FloEdelmann avatar Jul 09 '24 13:07 FloEdelmann

@ota-meshi can you take a look?

mpiniarski avatar Jul 30 '24 19:07 mpiniarski