docs icon indicating copy to clipboard operation
docs copied to clipboard

docs: add typing global custom directives

Open hmd-ali opened this issue 1 year ago • 4 comments

hmd-ali avatar Jul 27 '24 23:07 hmd-ali

Deploy Preview for vuejs ready!

Name Link
Latest commit c3a040704a6360d7268c47e794d2446941168ba4
Latest deploy log https://app.netlify.com/sites/vuejs/deploys/66a58774bb310700086ebd10
Deploy Preview https://deploy-preview-2951--vuejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 27 '24 23:07 netlify[bot]

@hmd-ali thank you for the PR! The change looks good but could we please move it to the TypeScript part of the guide? The rest of the directives documentation is plain JS, so adding typing guide looks a bit off. We can add a link at the bottom of directives doc to TS doc too.

NataliaTepluhina avatar Aug 13 '24 12:08 NataliaTepluhina

I just noticed your message @NataliaTepluhina. The TS sections are Overview, ts with composition and ts with options api. Where should it go as it's for both apis?

hmd-ali avatar Aug 21 '24 13:08 hmd-ali

I just noticed your message @NataliaTepluhina. The TS sections are Overview, ts with composition and ts with options api. Where should it go as it's for both apis?

I would probably split it in two and add to both APIs

NataliaTepluhina avatar Sep 26 '24 15:09 NataliaTepluhina