docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: the link address is incorrect after configuring the base URL

Open YanxinTang opened this issue 1 year ago • 3 comments

Description of Problem

Then link address is incorrect after configuring the base URL

When configuring the base URL like below:

{
    "base": "/base/"
}

Correct: '/base/some-link' Incorrect: '/some-link'

Proposed Solution

use withBase prepend base URL into the link

Additional Information

YanxinTang avatar Dec 22 '23 11:12 YanxinTang

Deploy Preview for vuejs ready!

Name Link
Latest commit 022cb98e800f67e6d69fb19c7265593b31697081
Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6586cc0d58e6f10008879eae
Deploy Preview https://deploy-preview-2622--vuejs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 22 '23 11:12 netlify[bot]

And why should we support that here? We aren’t using any base in the site. And I don’t think any translation project has that either.

brc-dd avatar Dec 23 '23 13:12 brc-dd

And why should we support that here? We aren’t using any base in the site. And I don’t think any translation project has that either.

For some security reasons, I cannot access the internet in the work environment.

The private internal docs site in my working environment requires supporting baseURL to deploy. So I have to handle the same stuff after updating to the latest doc. I want to solve from the source to avoid repeating meaningless work. And, I believe there's someone who needs this too.

This PR does not bring new things but it will improve the experience of personal deployment.

YanxinTang avatar Dec 24 '23 00:12 YanxinTang

@YanxinTang in that case I think it's better to maintain this in your personal fork as this PR does add unnecessary complexity which is something that we have to deal with in the long run.

yyx990803 avatar Mar 11 '24 07:03 yyx990803