docs icon indicating copy to clipboard operation
docs copied to clipboard

Enforce styling across the repo

Open bencodezen opened this issue 5 years ago • 5 comments

I'm noticing that we are having some different auto-formatting styles in some of the PRs. I'm thinking we should have an opinionated styling formatting for contributors going forward so we don't have large style changes going forward.

Proposal

This might be two pronged:

  • Include an opinionated .prettierrc file so people's autoformat follows the team's standard consistently
  • Add a pre-commit hook for linting and standardizing styles

What do you think @NataliaTepluhina @phanan @sdras?

bencodezen avatar Jul 18 '20 18:07 bencodezen

@bencodezen up for both options 👍🏻

NataliaTepluhina avatar Jul 18 '20 18:07 NataliaTepluhina

I'd vote for a pre-commit hook. Husky and lint-staged work pretty well for me.

phanan avatar Jul 18 '20 18:07 phanan

Agree with @phanan :)

sdras avatar Jul 18 '20 20:07 sdras

Is this still on the to-do list? If so, is someone working on this or can the community contribute this? Thanks.

schalkneethling avatar Apr 23 '22 19:04 schalkneethling

@schalkneethling Community contributions would certainly be welcome!

bencodezen avatar Apr 28 '22 18:04 bencodezen