devtools-next icon indicating copy to clipboard operation
devtools-next copied to clipboard

feat(client & devtools-kit): add route-meta for pages

Open wzc520pyfm opened this issue 1 year ago • 2 comments

hi~! I see #330 , this pr add route meta for pages.

Preview:

https://github.com/user-attachments/assets/4927ef5e-6832-412a-b755-6b6be41a3f61

wzc520pyfm avatar Aug 03 '24 16:08 wzc520pyfm

Deploy Preview for vue-devtools-docs canceled.

Name Link
Latest commit 966cc05c23b6210dc72718da5b5a3b8b076aa2ea
Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66d7396717bc7c0008c5bd5a

netlify[bot] avatar Aug 03 '24 16:08 netlify[bot]

the bundle size of json-editor-vue is above 500kb, this is huge... Since this is not a feature for high-frequency use, and most of the time is read instead of edited, how about just using Shiki for render meta info? We have a CodeBlock component on the @vue/devtools-ui package.

alexzhang1030 avatar Aug 06 '24 01:08 alexzhang1030

the bundle size of json-editor-vue is above 500kb, this is huge... Since this is not a feature for high-frequency use, and most of the time is read instead of edited, how about just using Shiki for render meta info? We have a CodeBlock component on the @vue/devtools-ui package.

Sorry for delay. I have replaced json-editor-vue with CodeBlock.

wzc520pyfm avatar Aug 31 '24 06:08 wzc520pyfm

Because the route meta info does not exist in every project, I think it is better UX to hide this field if all the routes of the user project do not have this field.

webfansplz avatar Sep 02 '24 15:09 webfansplz