core icon indicating copy to clipboard operation
core copied to clipboard

feat(compiler): compiler supports search tag

Open baiwusanyu-c opened this issue 2 years ago • 5 comments

close: #9247

baiwusanyu-c avatar Sep 19 '23 02:09 baiwusanyu-c

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.2 kB (+125 B) 29.8 kB (+45 B) 26.3 kB (+23 B)
runtime-dom.global.prod.js 103 kB (+65 B) 39.1 kB (+26 B) 35.2 kB (-22 B)
vue.global.prod.js 161 kB (+106 B) 59.3 kB (+33 B) 52.9 kB (+105 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.5 kB 18.6 kB 17 kB
createApp 55.9 kB 21.7 kB 19.8 kB
createApp + vaporInteropPlugin 67.9 kB 25.9 kB 23.6 kB
createVaporApp 20.8 kB 8.28 kB 7.57 kB
createSSRApp 60.2 kB 23.5 kB 21.4 kB
defineCustomElement 60.9 kB 23.2 kB 21.2 kB
overall 70.2 kB 26.9 kB 24.5 kB

github-actions[bot] avatar Sep 19 '23 02:09 github-actions[bot]

The way we handle built-in HTML tags makes this technically a breaking change if someone was previously having a component named search.

Right now:

  • If a tag is listed as built-in, it can't be registered as a component because the parser directly parses the tag as native.
  • If a tag is not listed as built-in but used in template, there will be a "failed to resolve component" warning.

Considering there might be more tags being added in the future, we might need to have a separate list of "late added tags". For these tags:

  • The parser will still parse them as potential components
  • At runtime, it will use a component with matching name if it is registered (but a "Do not use built-in tag..." warning is still thrown)
  • If no matching component is found, it falls back to render as native element, without the "failed to resolve component" warning.

yyx990803 avatar Oct 20 '23 10:10 yyx990803

To provide a concrete example of more new tag names that might get added. https://open-ui.org/components/selectlist/ OpenUI is currently working on a new stylable select element, as part of that proposal at least 3 new Html elements are currently proposed to be added. And it's likely that more such elements will be added as time goes on. So search is definitely not going to be a one of or even necessarily a rarity.

lukewarlow avatar Oct 21 '23 02:10 lukewarlow

The commit history in this pull request is quite extensive. Could you please squash the commits to make it more concise?

edison1105 avatar Oct 10 '24 08:10 edison1105

Because the minor branch is 2 commits ahead of main. We should update the minor branch first.

sxzz avatar Oct 10 '24 08:10 sxzz

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 07 '25 01:07 coderabbitai[bot]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@9249
@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@9249
@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@9249
@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@9249
@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@9249
@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@9249
@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@9249
@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@9249
@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@9249
@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@9249
@vue/shared

npm i https://pkg.pr.new/@vue/shared@9249
vue

npm i https://pkg.pr.new/vue@9249
@vue/compat

npm i https://pkg.pr.new/@vue/compat@9249

commit: 52369c2

pkg-pr-new[bot] avatar Jul 07 '25 13:07 pkg-pr-new[bot]

This pr adds a getSetupReturnedHelper function to the SFC compilation result to implement runtime component name judgment when using option api or setup script. When the component tag name belongs to 'lateTag', it will throw a warning, but still render the component.

preview

setup script option api As a dom tag

baiwusanyu-c avatar Jul 07 '25 13:07 baiwusanyu-c

We should also consider the following cases: Playground with this PR

edison1105 avatar Jul 08 '25 03:07 edison1105