feat(compiler): compiler supports search tag
close: #9247
Size Report
Bundles
| File | Size | Gzip | Brotli |
|---|---|---|---|
| compiler-dom.global.prod.js | 84.2 kB (+125 B) | 29.8 kB (+45 B) | 26.3 kB (+23 B) |
| runtime-dom.global.prod.js | 103 kB (+65 B) | 39.1 kB (+26 B) | 35.2 kB (-22 B) |
| vue.global.prod.js | 161 kB (+106 B) | 59.3 kB (+33 B) | 52.9 kB (+105 B) |
Usages
| Name | Size | Gzip | Brotli |
|---|---|---|---|
| createApp (CAPI only) | 47.5 kB | 18.6 kB | 17 kB |
| createApp | 55.9 kB | 21.7 kB | 19.8 kB |
| createApp + vaporInteropPlugin | 67.9 kB | 25.9 kB | 23.6 kB |
| createVaporApp | 20.8 kB | 8.28 kB | 7.57 kB |
| createSSRApp | 60.2 kB | 23.5 kB | 21.4 kB |
| defineCustomElement | 60.9 kB | 23.2 kB | 21.2 kB |
| overall | 70.2 kB | 26.9 kB | 24.5 kB |
The way we handle built-in HTML tags makes this technically a breaking change if someone was previously having a component named search.
Right now:
- If a tag is listed as built-in, it can't be registered as a component because the parser directly parses the tag as native.
- If a tag is not listed as built-in but used in template, there will be a "failed to resolve component" warning.
Considering there might be more tags being added in the future, we might need to have a separate list of "late added tags". For these tags:
- The parser will still parse them as potential components
- At runtime, it will use a component with matching name if it is registered (but a "Do not use built-in tag..." warning is still thrown)
- If no matching component is found, it falls back to render as native element, without the "failed to resolve component" warning.
To provide a concrete example of more new tag names that might get added. https://open-ui.org/components/selectlist/ OpenUI is currently working on a new stylable select element, as part of that proposal at least 3 new Html elements are currently proposed to be added. And it's likely that more such elements will be added as time goes on. So search is definitely not going to be a one of or even necessarily a rarity.
The commit history in this pull request is quite extensive. Could you please squash the commits to make it more concise?
Because the minor branch is 2 commits ahead of main. We should update the minor branch first.
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@vue/compiler-core
npm i https://pkg.pr.new/@vue/compiler-core@9249
@vue/compiler-dom
npm i https://pkg.pr.new/@vue/compiler-dom@9249
@vue/compiler-sfc
npm i https://pkg.pr.new/@vue/compiler-sfc@9249
@vue/compiler-ssr
npm i https://pkg.pr.new/@vue/compiler-ssr@9249
@vue/compiler-vapor
npm i https://pkg.pr.new/@vue/compiler-vapor@9249
@vue/reactivity
npm i https://pkg.pr.new/@vue/reactivity@9249
@vue/runtime-core
npm i https://pkg.pr.new/@vue/runtime-core@9249
@vue/runtime-dom
npm i https://pkg.pr.new/@vue/runtime-dom@9249
@vue/runtime-vapor
npm i https://pkg.pr.new/@vue/runtime-vapor@9249
@vue/server-renderer
npm i https://pkg.pr.new/@vue/server-renderer@9249
@vue/shared
npm i https://pkg.pr.new/@vue/shared@9249
vue
npm i https://pkg.pr.new/vue@9249
@vue/compat
npm i https://pkg.pr.new/@vue/compat@9249
commit: 52369c2
This pr adds a getSetupReturnedHelper function to the SFC compilation result to implement runtime component name judgment when using option api or setup script. When the component tag name belongs to 'lateTag', it will throw a warning, but still render the component.
preview
We should also consider the following cases: Playground with this PR