core icon indicating copy to clipboard operation
core copied to clipboard

fix(reactivity): shallowReactive map "unwraps" the nested refs

Open liuseen-l opened this issue 1 year ago • 5 comments

[BREAKING CHANGE]

fix https://github.com/vuejs/core/issues/11249 fix https://github.com/vuejs/core/issues/8501 closes #8502

although pr #8502 fix #8501 issue, it is a destructive fix for shallowReactive, so i take a relatively elegant approach to the issue. At the same time, there are also the same issues with Set, so they have been modified together

liuseen-l avatar Jun 05 '23 11:06 liuseen-l

/ecosystem-ci run

sxzz avatar Aug 24 '23 12:08 sxzz

📝 Ran ecosystem CI: Open

suite result
nuxt :white_check_mark: success
pinia :white_check_mark: success
quasar :x: failure
router :white_check_mark: success
test-utils :white_check_mark: success
vant :white_check_mark: success
vite-plugin-vue :white_check_mark: success
vitepress :white_check_mark: success
vue-i18n :white_check_mark: success
vue-macros :x: failure
vuetify :white_check_mark: success
vueuse :white_check_mark: success
vue-simple-compiler :white_check_mark: success

vue-bot avatar Aug 24 '23 12:08 vue-bot

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+76 B) 32.7 kB (+38 B) 29.5 kB (+33 B)
vue.global.prod.js 132 kB (+76 B) 49.4 kB (+32 B) 44.4 kB (+64 B)

Usages

Name Size Gzip Brotli
createApp 48 kB (+76 B) 18.9 kB (+34 B) 17.2 kB (+26 B)
createSSRApp 50.7 kB (+76 B) 20 kB (+31 B) 18.2 kB (+29 B)
defineCustomElement 50.3 kB (+76 B) 19.7 kB (+34 B) 17.9 kB (+35 B)
overall 61.3 kB (+76 B) 23.7 kB (+32 B) 21.5 kB (-14 B)

github-actions[bot] avatar Aug 24 '23 12:08 github-actions[bot]

there are also the same issues with Set

Shouldn't there be a test for Set as well in that case?

jacekkarczmarczyk avatar Apr 18 '24 03:04 jacekkarczmarczyk