core icon indicating copy to clipboard operation
core copied to clipboard

feat: support `v-model` for `<details>` and `<dialog>`

Open antfu opened this issue 3 years ago • 4 comments

  • RFC: https://github.com/vuejs/rfcs/pull/496
  • Docs PR: https://github.com/vuejs/docs/pull/2315
  • Playground Preview

antfu avatar Apr 08 '23 10:04 antfu

Looks like this is lacking runtime behavior tests in https://github.com/vuejs/core/blob/main/packages/runtime-dom/tests/directives/vModel.spec.ts

yyx990803 avatar Apr 10 '23 06:04 yyx990803

Test added, resolveDynamicModel updated.

antfu avatar Apr 10 '23 09:04 antfu

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.2 kB (+433 B) 32.7 kB (+97 B) 29.5 kB (+90 B)
vue.global.prod.js 132 kB (+568 B) 49.4 kB (+125 B) 44.3 kB (+35 B)

Usages

Name Size Gzip Brotli
createApp 47.7 kB 18.9 kB 17.2 kB
createSSRApp 50.5 kB 19.9 kB 18.2 kB
defineCustomElement 50.1 kB 19.6 kB 17.9 kB
overall 61.1 kB 23.7 kB 21.6 kB

github-actions[bot] avatar Aug 21 '23 08:08 github-actions[bot]

Hello! I didn't see this particular feature mentioned in 3.4 release candidate. Is this still planned? Thanks.

amir20 avatar Dec 15 '23 03:12 amir20