core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

fix(runtime-core): Fix cssVar cannot work in teleport

Open tinyfind opened this issue 2 years ago • 4 comments
trafficstars

close: #7312 close: #7342

tinyfind avatar Dec 17 '22 13:12 tinyfind

Could you maybe explain how your proposed solution compares to the existing PRs for those two issues?

  • #7341
  • #7344

skirtles-code avatar Dec 17 '22 20:12 skirtles-code

discard use css attribute data-v-owner that cancel updateCssVars limit browser environment only, so #7341 get fixed modify updateCssVars make cssVar can work in multilevel nesting teleport https://github.com/vuejs/core/blob/fe77e2bddaa5930ad37a43fe8e6254ddb0f9c2d7/packages/runtime-core/src/components/Teleport.ts#L401 modify setVarsOnVNode add handle for Teleport vnode and use MutationObserver to trigger that #7342 get fixed

tinyfind avatar Dec 18 '22 05:12 tinyfind

@sxzz can you help me to review.

tinyfind avatar Jan 10 '23 01:01 tinyfind

@tinyfind can you provide answers for skirtles questions please?

Could you maybe explain how your proposed solution compares to the existing PRs for those two issues?

pikax avatar Oct 20 '23 07:10 pikax