core icon indicating copy to clipboard operation
core copied to clipboard

fix(runtime): CSSVars can work with Teleport

Open baiwusanyu-c opened this issue 2 years ago β€’ 12 comments

close: #7312

baiwusanyu-c avatar Dec 14 '22 08:12 baiwusanyu-c

see here bug seem still alive

moushicheng avatar Dec 14 '22 12:12 moushicheng

I store the 'data-owner-value' in the 'parentComponent' when the element is unmounted, and reset it when it is updated. And maintain a variable 'teleportUTMap' globally, store 'ut', re-execute 'ut' when updating,

baiwusanyu-c avatar Dec 16 '22 08:12 baiwusanyu-c

@baiwusanyu-c great work! but not working with this scenario

edison1105 avatar Dec 16 '22 08:12 edison1105

@baiwusanyu-c great work! but not working with this scenario

ok,let me see how to fix

baiwusanyu-c avatar Dec 16 '22 08:12 baiwusanyu-c

Do some refinement and unit testing tomorrow 🀣

baiwusanyu-c avatar Dec 16 '22 13:12 baiwusanyu-c

Deploy Preview for vuejs-coverage failed.

Name Link
Latest commit f4a605c95dc31b29399aacef4b7bcdf24c7272a9
Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/639c7209abc1860008079a4f

netlify[bot] avatar Dec 16 '22 13:12 netlify[bot]

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Updated (UTC)
sfc-playground ⬜️ Ignored (Inspect) Apr 6, 2023 0:44am

vercel[bot] avatar Apr 06 '23 12:04 vercel[bot]

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 91.3 kB (+675 B) 34.7 kB (+212 B) 31.2 kB (+156 B)
vue.global.prod.js 148 kB (+675 B) 54 kB (+212 B) 48.2 kB (+140 B)

Usages

Name Size Gzip Brotli
createApp 51.1 kB (+345 B) 20 kB (+118 B) 18.2 kB (+90 B)
createSSRApp 54.4 kB (+345 B) 21.3 kB (+103 B) 19.4 kB (+134 B)
defineCustomElement 53.4 kB (+345 B) 20.7 kB (+108 B) 18.9 kB (+140 B)
overall 64.8 kB (+345 B) 25 kB (+102 B) 22.6 kB (+89 B)

github-actions[bot] avatar Oct 20 '23 09:10 github-actions[bot]

CodSpeed Performance Report

Merging #7344 will not alter performance

Comparing baiwusanyu-c:bwsy/fix/teleportCSSVars (e3e85d5) with main (bae79dd)

Summary

βœ… 53 untouched benchmarks

codspeed-hq[bot] avatar Dec 19 '23 09:12 codspeed-hq[bot]

/ecosystem-ci run

haoqunjiang avatar Apr 02 '24 14:04 haoqunjiang

πŸ“ Ran ecosystem CI: Open

suite result latest scheduled
language-tools :white_check_mark: success :white_check_mark: success
nuxt :x: failure :white_check_mark: success
pinia :white_check_mark: success :white_check_mark: success
quasar :white_check_mark: success :white_check_mark: success
radix-vue :white_check_mark: success :white_check_mark: success
router :white_check_mark: success :white_check_mark: success
test-utils :white_check_mark: success :white_check_mark: success
vant :white_check_mark: success :white_check_mark: success
vite-plugin-vue :white_check_mark: success :white_check_mark: success
vitepress :white_check_mark: success :white_check_mark: success
vue-i18n :white_check_mark: success :white_check_mark: success
vue-macros :white_check_mark: success :white_check_mark: success
vuetify :white_check_mark: success :white_check_mark: success
vueuse :white_check_mark: success :white_check_mark: success
vue-simple-compiler :white_check_mark: success :white_check_mark: success

vue-bot avatar Apr 02 '24 14:04 vue-bot

Since this PR adds a new export to the @vue/runtime-core package, I think it should be shipped in a minor version.

The Nuxt test failure was due to this. Not a blocker, though.

haoqunjiang avatar Apr 02 '24 14:04 haoqunjiang