core icon indicating copy to clipboard operation
core copied to clipboard

sourcemap-codec deprecated warning

Open kingyue737 opened this issue 2 years ago β€’ 1 comments

Vue version

3.2.45

Link to minimal reproduction

Ignore

Steps to reproduce

Install a package depending on @vue/reactivity-transform or @vue/compiler-sfc. These two packages use magic-string of an old version which depends on deprecated sourcemap-codec

What is expected?

No warning

What is actually happening?

PNPM gives the following warning:

 WARN  deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead

System Info

No response

Any additional comments?

According to sxzz, require https://github.com/rollup/plugins/pull/1373 to be merged

kingyue737 avatar Dec 12 '22 11:12 kingyue737

We also have to wait @rollup/plugin-commonjs, rollup-plugin-node-polyfills, @rollup/plugin-inject, @rollup/plugin-replace to upgrade their magic-string deps.

relate PR https://github.com/rollup/plugins/pull/1373

sxzz avatar Dec 13 '22 06:12 sxzz

https://github.com/rollup/plugins/pull/1373 is merged :)

ice1000 avatar Dec 17 '22 20:12 ice1000

https://github.com/remorses/esbuild-plugins/pull/19 This PR is also blocking...

sxzz avatar Dec 17 '22 20:12 sxzz

I was about to open an issue but I see you all are already on top of it. Keep up the great work, team Vue!

burkenyo avatar Jan 24 '23 04:01 burkenyo

https://github.com/remorses/esbuild-plugins/pull/19 is merged!

ice1000 avatar Jan 26 '23 15:01 ice1000

@ice1000 Unfortunately it's reversed 😒 https://github.com/remorses/esbuild-plugins/issues/28#issuecomment-1406309742

MichaelDeBoey avatar Jan 28 '23 15:01 MichaelDeBoey

Is there any quick fix for that?

MBoretto avatar Jan 31 '23 12:01 MBoretto

@MBoretto The fix would be helping me re-implement it in https://github.com/remorses/esbuild-plugins/pull/29 without that bug πŸ€·β€β™‚οΈ

MichaelDeBoey avatar Jan 31 '23 22:01 MichaelDeBoey

I added https://github.com/remorses/esbuild-plugins/pull/32 on top of @MichaelDeBoey PR to fix those internal modules. It's quite hard to test in that repo but I think it solve the issue.

p-m-p avatar Feb 01 '23 14:02 p-m-p

Has the problem been resolved?

1581433801 avatar Apr 26 '23 14:04 1581433801

Fixed in v3.3.0-alpha.6.

@esbuild-plugins/node-modules-polyfill is a dev dep and won't affect in userland.

sxzz avatar Apr 27 '23 00:04 sxzz

Nice!!

ice1000 avatar Apr 27 '23 01:04 ice1000