core icon indicating copy to clipboard operation
core copied to clipboard

fix(reactivity-transform): semicolon after statements with nested destructure

Open skywalker512 opened this issue 2 years ago • 2 comments

This commit adds a new semicolon after the reactivity-transform statements, but there may be problems with the nested destructure, here's a demo

image

skywalker512 avatar Dec 06 '22 06:12 skywalker512

Deploy Preview for vuejs-coverage failed.

Name Link
Latest commit 22263948e47df681dfe5618a3660ec5839598619
Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/638edd33f39664000828355b

netlify[bot] avatar Dec 06 '22 06:12 netlify[bot]

I just realized that it's not a necessity to add a semicolon after _toRef function of Reactivity Transform.

From the example of #6303, we should only add a semicolon in the first rectangle. It's actually not the scope of the reactivity transform, and it works now. But as the second rectangle, a semicolon should be added by $$ macro, instead of $ macro. image

So let's track issue #6312 and discuss it I guess.

sxzz avatar Dec 10 '22 18:12 sxzz

Unfortunately, Reactivity Transform has been dropped officially now, so I closed this issue/PR. If you want to keep using it, please consider the community version Vue Macros.

sxzz avatar Jan 26 '23 08:01 sxzz