core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

fix(compiler/runtime-dom): firefox do not support regexp flag `s`

Open rudyxu1102 opened this issue 2 years ago • 1 comments

Fix #7267

Related to #6808 #3917

Playground

rudyxu1102 avatar Dec 03 '22 06:12 rudyxu1102

I prefer to use \s\S instead of (.|\n) since some cases have already used it.

https://github.com/vuejs/core/blob/fe77e2bddaa5930ad37a43fe8e6254ddb0f9c2d7/packages/compiler-core/src/transforms/vFor.ts#L311

Thanks

rudyxu1102 avatar Dec 11 '22 03:12 rudyxu1102

Safari on iOS < 12 also impacted

stondbringa avatar Mar 30 '23 14:03 stondbringa

May I ask when this PR will be merged? This compatibility issue may have a significant impact on the business.

godxiaoji avatar May 08 '23 01:05 godxiaoji

I have the same issue, plz merge this PR!

nickcarterney avatar May 09 '23 03:05 nickcarterney

UP for merge! Please pay attention to this PR

safonov-ruslan avatar May 09 '23 09:05 safonov-ruslan

For whom may concern, the issue patched in v3.3.4 see https://github.com/vuejs/core/commit/91f1c62e6384a8b09f90e7e43b8d347901e529a0

TNGD-YQ avatar May 31 '23 06:05 TNGD-YQ

I confirm, issue is fixed in v3.3.4. Tested on Safari on iOS < 12 and firefox < 72

stondbringa avatar May 31 '23 09:05 stondbringa

@stondbringa @TNGD-YQ thanks.

edison1105 avatar May 31 '23 09:05 edison1105

Can this change be merged into version 3.2.x. The current version and accompanying tools (such as vite) no longer support Windows 7 (Node <13). Not very friendly to developers who cannot upgrade their systems (such as work computers).

godxiaoji avatar Jun 01 '23 00:06 godxiaoji