core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

fix: stricter type condition for `EventHandlers`

Open johnsoncodehk opened this issue 3 years ago • 3 comments

Issue: https://github.com/johnsoncodehk/volar/issues/1985

With @types/node version >= 18.8.1, MouseEvent extends Function is true, but with version <= 18.8.0 MouseEvent extends Function is false.

johnsoncodehk avatar Oct 11 '22 21:10 johnsoncodehk

Will this fix also be applied for Vue 2.7.x ?

d-koppenhagen avatar Oct 12 '22 11:10 d-koppenhagen

why has this been sitting for 2 days? it's chaos for volar

acidjazz avatar Oct 14 '22 17:10 acidjazz

@acidjazz We may need cautious to check if the change leads to some regressions, so please be patient. :)

Downgrading @types/node to 18.8.0 for now is fine.

johnsoncodehk avatar Oct 14 '22 21:10 johnsoncodehk

FYI the issue has been fixed in @types/node v18.11.1+ https://github.com/DefinitelyTyped/DefinitelyTyped/pull/62782 so you don't have to wait for this PR to be merged to update your @types/node version.

haoqunjiang avatar Oct 20 '22 16:10 haoqunjiang

@sodatea I have 18.11.3 but the error is there.

iBobik avatar Oct 23 '22 14:10 iBobik