core icon indicating copy to clipboard operation
core copied to clipboard

fix(compiler-sfc): ignore style comment in `transform` stage

Open rudyxu1102 opened this issue 3 years ago • 2 comments

Fix #6807

rudyxu1102 avatar Oct 02 '22 09:10 rudyxu1102

The behavior of the compile seems like it's not a bug.

I think it would be better to fix it here: https://github.com/vuejs/core/blob/85af1398637ee91c6ebabb73bf42250320311e19/packages/runtime-dom/src/modules/style.ts#L40-L66

zhangzhonghe avatar Oct 02 '22 10:10 zhangzhonghe

The behavior of the compile seems like it's not a bug.

I think it would be better to fix it here:

https://github.com/vuejs/core/blob/85af1398637ee91c6ebabb73bf42250320311e19/packages/runtime-dom/src/modules/style.ts#L40-L66

Thanks, it's a good point. But I still think the compiler should know this is a comment, not a property of style.

rudyxu1102 avatar Oct 03 '22 07:10 rudyxu1102

Deploy Preview for vuejs-coverage failed.

Name Link
Latest commit 00bbd29285f508ac03f7d45e52d6d5a2f6dca4d3
Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6369ced11e175f00084724dd

netlify[bot] avatar Nov 08 '22 03:11 netlify[bot]