core fix(runtime-core): delete stale slots which are present but undefined

fix(runtime-core): delete stale slots which are present but undefined

Open KaelWD opened this issue 3 years ago • 2 comments

If slots.loader becomes undefined, slots.default in LoaderSlot was still the old value because the key is still present

<v-field>
  <template v-if="custom" #loader>
    <v-progress-linear />
  </template>
</v-field>

<LoaderSlot v-slots={{ default: slots.loader }} />

Aug 16 '22 19:08 KaelWD

@sxzz Will it be merged？

Dec 12 '22 02:12 haiweilian

@KaelWD Thanks for the PR, could you add a test?

Dec 12 '22 03:12 zhangzhonghe

@zhangzhonghe tests updated

Mar 21 '23 06:03 KaelWD

/ecosystem-ci run

Mar 21 '23 08:03 sxzz

📝 Ran ecosystem CI: Open

Mar 21 '23 08:03 vue-bot

/ecosystem-ci run

Sep 01 '23 17:09 sxzz

📝 Ran ecosystem CI: Open

Sep 01 '23 17:09 vue-bot

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	85.9 kB (+4 B)	32.6 kB (+1 B)	29.5 kB (-3 B)
vue.global.prod.js	132 kB (+4 B)	49.3 kB	44.3 kB (-16 B)

Name	Size	Gzip	Brotli
createApp	47.9 kB (+4 B)	18.8 kB (+1 B)	17.2 kB (+55 B)
createSSRApp	50.6 kB (+4 B)	20 kB (+2 B)	18.2 kB (+3 B)
defineCustomElement	50.3 kB (+4 B)	19.6 kB (+2 B)	17.9 kB (+1 B)
overall	61.2 kB (+4 B)	23.7 kB (+1 B)	21.5 kB (-40 B)

Sep 01 '23 17:09 github-actions[bot]

CI failed. Could you please format your files? pnpm run format

Sep 02 '23 16:09 sxzz

That adds a bunch of other changes in unrelated files.

Sep 07 '23 12:09 KaelWD