core icon indicating copy to clipboard operation
core copied to clipboard

feat(effectScope): add `active` property getter

Open webfansplz opened this issue 2 years ago • 2 comments

Close #6186

webfansplz avatar Jun 27 '22 03:06 webfansplz

The problem with this change is that now we communicate via our types that it's fine to mutate this property in userland - it's part of the types, after all. But that's not* what people should be doing.

So I think a better solution would be to have a dedicated getter for retrieving this information.

LinusBorg avatar Jun 27 '22 07:06 LinusBorg

The problem with this change is that now we communicate via our types that it's fine to mutate this property in userland - it's part of the types, after all. But that's not* what people should be doing.

So I think a better solution would be to have a dedicated getter for retrieving this information.

Updated,Thanks for your suggestion.

webfansplz avatar Jun 27 '22 08:06 webfansplz