core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon vuejs

fix(compiler-core): KeepAlive should ignore comments

Open amirkian007 opened this issue 3 years ago • 5 comments

KeepAlive does not ignore comments and the compiler throws an error when a component and a comment are wrapped with KeepAlive, which is obviously a bug.

error reproduction :

sfc.vuejs.org

thanks.

amirkian007 avatar May 29 '22 18:05 amirkian007

Deploy Preview for vuejs-coverage failed.

Name Link
Latest commit 77f5d447f3baf6dbc781e022435ca50e5d476d5c
Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/62a223332e6a04000831b817

netlify[bot] avatar Jun 09 '22 16:06 netlify[bot]

@tony19 hi can you re-review my new changes please ? the re-request review button not working...

amirkian007 avatar Jun 10 '22 11:06 amirkian007

Comments cannot be ignored directly

iwusong avatar Jun 22 '22 03:06 iwusong

https://staging-cn.vuejs.org/api/application.html#app-config-compileroptions

comments need final rendering on dom

iwusong avatar Jun 22 '22 03:06 iwusong

https://staging-cn.vuejs.org/api/application.html#app-config-compileroptions

comments need final rendering on dom

yeah comments should be rendered on the dom and the same problem exists for other built-in components too like Transition ,Suspense and etc . i dont know if it is a bug or not. but if it is, i think the fix for that should be submitted in another pr , this one is to just fix the warning issue with the compiler

amirkian007 avatar Jun 23 '22 16:06 amirkian007